Deserialize Option<T> in place when T needs drop#3040
Open
gstvg wants to merge 1 commit intoserde-rs:masterfrom
Open
Deserialize Option<T> in place when T needs drop#3040gstvg wants to merge 1 commit intoserde-rs:masterfrom
gstvg wants to merge 1 commit intoserde-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needing Drop should be good enough to estimate whether branching on the old value is profitable or not: a quick check on Deserialize impl's of the crate show that it holds for all of them. And if not, the Drop impl might be more costly than the added branch anyway.
And for the std::mem::needs_drop check, since it's const since 1.36, it should be elided