Support noFrozenLockfile options#687
Merged
j0k3r merged 1 commit intoserverless-heaven:masterfrom Feb 1, 2021
Merged
Conversation
Contributor
Author
3aaf0dd to
2173ca7
Compare
Member
j0k3r
approved these changes
Feb 1, 2021
Member
|
Thanks @tgroutars! |
Contributor
Author
|
No, thank you 🙏 |
Member
|
I added it to the next release the 5.4.0. |
This was referenced Mar 18, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
We have a monorepo with several serverless packages. Given the way we do CI and the way
lernadeals with lockfiles, we actually don't need and don't have an up to dateyarn.lock, but for our usecase it doesn't really matter.This adds the option
noFrozenLockfiletopackagerOptions, allowing to runyarn installwithout the--no-frozen-lockfileoption. This is as suggested in this comment #369 (comment)I also fixed the documentation for
ignoreScriptsin the README, which mentioned a default value oftruewhen it is in factfalseHow did you implement it:
Added the option in the
installfunction inyarn.jsHow can we verify it:
I added tests to make sure the option was omitted when using
noFrozenLockfileTodos:
Is this ready for review?: YES
Is it a breaking change?: NO