This repository was archived by the owner on Apr 23, 2026. It is now read-only.
gst: Use buffered ranges with precise position timestamps#468
Merged
jdm merged 1 commit intoNov 20, 2025
Merged
Conversation
Buffered ranges from the gstreamer backend must contain the precise position timestamps (not rounded to the nearest second). Continuation servo#460 Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
Contributor
Author
|
@jdm < Please take a look. |
Taym95
approved these changes
Nov 20, 2025
| metadata.duration.map_or(std::f64::INFINITY, |duration| duration.as_secs_f64()); | ||
| playerstate.duration = metadata | ||
| .duration | ||
| .map_or(std::f64::INFINITY, |duration| duration.as_secs_f64()); |
Contributor
Author
There was a problem hiding this comment.
Yes, i run cargo fmt command (same as in #459)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffered ranges from the gstreamer backend must contain the precise position timestamps (not rounded to the nearest second).
Continuation #460