Merged
Conversation
This is a workaround for BurntSushi/ripgrep#2711 Fixes: sharkdp#1461
tmccombs
force-pushed
the
gitignore-workaround
branch
from
3cc90f5 to
a7b5e08
Compare
tavianator
requested changes
Apr 28, 2024
Collaborator
tavianator
left a comment
tavianator
left a comment
There was a problem hiding this comment.
I think this workaround is incomplete: we should do the same thing if the user passes . as a path explicitly.
It's also worth adding a test case I think.
And make sure it works for user-supplied path of "." Also add changelog entry
tavianator
approved these changes
Apr 30, 2024
sharkdp
reviewed
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for bug with gitinored files
This is a workaround for
BurntSushi/ripgrep#2711
Fixes: #1461