fix: XLSX response_time variable collision, folderoutput support, and notify counter#2796
Open
matthew6s wants to merge 1 commit intosherlock-project:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs found during code review:
Bug 1: XLSX
response_time_svariable collision (sherlock.py:913)response_time_sis initialized as[]on line 903, then checkedwith
is Noneon line 913. A list is neverNone, so the conditionis dead code —
Nonequery times get appended as-is instead ofbeing converted to empty strings.
This matches the pattern already used in CSV output (line 882-884).
Bug 2: XLSX ignores
--folderoutputflag (sherlock.py:935)CSV output correctly respects
--folderoutput(lines 856-859),but XLSX always writes to the current directory. Added the same
folder handling logic.
Bug 3: Global mutable counter in notify.py
globvaris a module-level global that persists across multipleusername scans. Combined with
finish()callingcountResults()(which increments) then subtracting 1, the reported count can be
wrong on multi-username runs. Replaced with an instance variable
on
QueryNotifyPrint.