feat: async engine with aiohttp for ~2x performance improvement#2798
Open
matthew6s wants to merge 1 commit intosherlock-project:masterfrom
Open
feat: async engine with aiohttp for ~2x performance improvement#2798matthew6s wants to merge 1 commit intosherlock-project:masterfrom
matthew6s wants to merge 1 commit intosherlock-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2797
Summary
Adds an async engine using
aiohttpas a drop-in replacement for the synchronousrequests-futuresThreadPoolExecutor approach.Benchmark Results (real-world, 478 sites)
The async engine is ~1.8x faster and found an additional result that the sync engine missed (likely due to more efficient connection handling).
Changes
sherlock_project/async_engine.pysherlock_project/sherlock.pypyproject.tomlaiohttpdependencyNew CLI Flags
--workers N, -w N— max concurrent requests (default: 100)--sync— use legacy synchronous engineBackwards Compatibility
--syncpreserves the existing behavior exactlyNew Dependency
aiohttp ^3.9.0