Skip to content

[SHRINKRES-345] Remove automatic activation of dependency version bum…#239

Merged
petrberan merged 1 commit intoshrinkwrap:masterfrom
xjusko:remove-automatic-activation-of-version-bump-script
Aug 6, 2024
Merged

[SHRINKRES-345] Remove automatic activation of dependency version bum…#239
petrberan merged 1 commit intoshrinkwrap:masterfrom
xjusko:remove-automatic-activation-of-version-bump-script

Conversation

@xjusko
Copy link
Copy Markdown
Contributor

@xjusko xjusko commented Jul 25, 2024

@xjusko xjusko requested a review from petrberan July 25, 2024 18:53
@petrberan
Copy link
Copy Markdown
Member

@xjusko The JIRA states that the script should be run via profile. Which profile is used to run the script?

@xjusko
Copy link
Copy Markdown
Contributor Author

xjusko commented Jul 29, 2024

@xjusko The JIRA states that the script should be run via profile. Which profile is used to run the script?

@petrberan You can run the script when building the project with -Pdependency-version-bump-unix flag, so for example:
mvn clean install -Pdependency-version-bump-unix
Or did I misunderstand what you meant by "run via profile"?

@xjusko xjusko force-pushed the remove-automatic-activation-of-version-bump-script branch from 436de43 to 55bf16a Compare August 5, 2024 09:56
Copy link
Copy Markdown
Member

@petrberan petrberan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @xjusko

@petrberan petrberan merged commit cb55dce into shrinkwrap:master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants