Conversation
…rate limit Changes made in this commit: - Modified: internal/handlers/private/setting.go - Modified: web/admin/src/routes/+layout.ts Key changes: - Handle GitHub API errors gracefully in Version handler - Continue without update information when GitHub API is unavailable - Remove incorrect 500 status handling in frontend layout - Prevent infinite redirect loop when GitHub API rate limits The application now correctly handles GitHub API rate limiting and other transient errors without redirecting users to the installation page. Backend middleware InstallCheck already handles installation status checks, so frontend should not assume 500 errors mean the app is not installed. Fixes #271
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rate limit
Changes made in this commit:
Key changes:
The application now correctly handles GitHub API rate limiting and other transient errors without redirecting users to the installation page. Backend middleware InstallCheck already handles installation status checks, so frontend should not assume 500 errors mean the app is not installed.
Fixes #271
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/