Skip to content

🐛 fix(api): prevent incorrect redirect to install page on GitHub API …#272

Merged
shurco merged 1 commit intomainfrom
271-bug-incorrect-redirect-to-install-page-on-500-errors-when-installing
Jan 27, 2026
Merged

🐛 fix(api): prevent incorrect redirect to install page on GitHub API …#272
shurco merged 1 commit intomainfrom
271-bug-incorrect-redirect-to-install-page-on-500-errors-when-installing

Conversation

@shurco
Copy link
Owner

@shurco shurco commented Jan 27, 2026

…rate limit

Changes made in this commit:

  • Modified: internal/handlers/private/setting.go
  • Modified: web/admin/src/routes/+layout.ts

Key changes:

  • Handle GitHub API errors gracefully in Version handler
  • Continue without update information when GitHub API is unavailable
  • Remove incorrect 500 status handling in frontend layout
  • Prevent infinite redirect loop when GitHub API rate limits

The application now correctly handles GitHub API rate limiting and other transient errors without redirecting users to the installation page. Backend middleware InstallCheck already handles installation status checks, so frontend should not assume 500 errors mean the app is not installed.

Fixes #271

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

…rate limit

Changes made in this commit:
- Modified: internal/handlers/private/setting.go
- Modified: web/admin/src/routes/+layout.ts

Key changes:
- Handle GitHub API errors gracefully in Version handler
- Continue without update information when GitHub API is unavailable
- Remove incorrect 500 status handling in frontend layout
- Prevent infinite redirect loop when GitHub API rate limits

The application now correctly handles GitHub API rate limiting
and other transient errors without redirecting users to the
installation page. Backend middleware InstallCheck already
handles installation status checks, so frontend should not
assume 500 errors mean the app is not installed.

Fixes #271
@shurco shurco linked an issue Jan 27, 2026 that may be closed by this pull request
3 tasks
@shurco shurco merged commit 3bb28ff into main Jan 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Incorrect Redirect to Install Page on 500 Errors When Installing

1 participant