feature core/input: validation in input components#2278
Open
1307-Dev wants to merge 73 commits intosiemens:mainfrom
Open
feature core/input: validation in input components#22781307-Dev wants to merge 73 commits intosiemens:mainfrom
1307-Dev wants to merge 73 commits intosiemens:mainfrom
Conversation
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
|
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
9 tasks
…ve type annotations in tests
…m:1307-Dev/ix into (feature/core)validation-input-components
|
…m:1307-Dev/ix into (feature/core)validation-input-components
- Refactored validation logic in DateInput and TimeInput components to utilize new picker methods. - Introduced context-based picker methods for better state management and validation handling. - Removed redundant code and improved the structure of input methods for clarity and maintainability. - Updated event handling to streamline input validation and dropdown interactions. - Enhanced the common input utilities to support new validation and event handling patterns.
…ate management - Introduced new utility functions for managing dropdown visibility and input validation. - Refactored state management in BasePickerInput to improve reactivity and maintainability. - Added support for class mutation observers to handle dynamic class changes. - Updated picker input methods to streamline event handling and validation synchronization. - Created a new types file for picker input to centralize type definitions and improve code clarity. - Simplified input rendering logic and improved integration with dropdown components.
…nd time components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
…m:1307-Dev/ix into (feature/core)validation-input-components
…ion-input-components
…ithub.com/1307-Dev/ix into (feature/core)validation-input-components
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
There are some errors which prevent validations from happening has expected.
GitHub Issue Number: #1799
JIRA: IX-2595
🆕 What is the new behavior?
The acceptance criteria for this ticket has been met-
Required input:
Invalid input > Removing value with keyboard > Stays invalid
Invalid input > Remove touched state (e.g. clear button) > Valid again
Invalid input > Programmatically setting it to empty > Stays invalid
Valid input > Removing value with keyboard > It is invalid
Valid input > Remove touched state (e.g. clear button) > Valid
Valid input > Programmatically setting it to empty > It is invalid
Not required input:
Invalid input > Removing value with keyboard > Valid
Invalid input > Remove touched state (e.g. clear button) > Valid again
Invalid input > Programmatically setting it to empty > Valid
Valid input > Removing value with keyboard > Valid
Valid input > Remove touched state (e.g. clear button) > Valid
Valid input > Programmatically setting it to empty > Valid
Furthermore a clear method has been added to all components to remove all validations and inputs added.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support