Added hotfix for formsubmit on enter keydown.

[1307-Dev]

💡 What is the current behavior?

Form submit on enter down is only limited when the button used is native with type submit. Does not submit when the button used is ix-button with type submit
GitHub Issue Number: #2362
JIRA Issue Number:IX-3895

🆕 What is the new behavior?

The form now submits when ix-button with type=submit is used. Adjusted the utility function to have a more robust submission. Modified the form ready tests to reflect the same behaviour.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

• 🦮 Accessibility (a11y) features were implemented
• 🗺️ Internationalization (i18n) - no hard coded strings
• 📲 Responsiveness - components handle viewport changes and content overflow gracefully
• 📕 Add or update a Storybook story
• 📄 Documentation was reviewed/updated siemens/ix-docs
• 🧪 Unit tests were added/updated and pass (pnpm test)
• 📸 Visual regression tests were added/updated and pass (Guide)
• 🧐 Static code analysis passes (pnpm lint)
• 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

[changeset-bot]

🦋 Changeset detected

Latest commit: 6a0fc7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@siemens/ix	Patch
@siemens/ix-angular	Patch
@siemens/ix-docs	Patch
@siemens/ix-react	Patch
@siemens/ix-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @1307-Dev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where forms containing an ix-button with type="submit" failed to submit upon pressing the Enter key. The changes enhance the form submission utility to reliably detect and activate ix-button elements, ensuring consistent form behavior. Additionally, comprehensive tests have been introduced to validate this corrected functionality across different button types.

Highlights

• Enhanced Form Submission Logic: The utility function handleSubmitOnEnterKeydown has been updated to correctly identify and trigger form submission when an ix-button with type="submit" is used.
• Improved ix-button Support: Previously, forms with ix-button[type="submit"] did not submit on Enter keydown; this behavior is now resolved, ensuring consistent form submission across different button types.
• Updated Test Coverage: The form-ready component tests have been expanded to include scenarios for both native <button type="submit"> and <ix-button type="submit">, ensuring robust validation of the fix.

Changelog

• packages/core/src/components/input/input.util.ts
  • Refactored the handleSubmitOnEnterKeydown function to prioritize finding a native button[type="submit"]. If not found, it now specifically looks for an ix-button[type="submit"] and then attempts to locate a native button within it to correctly trigger form.requestSubmit().
• packages/core/src/components/input/tests/form-ready.ct.ts
  • Modified the regression test for form submission on Enter keydown to iterate and test both native <button type="submit"> and <ix-button type="submit"> elements, ensuring the fix is verified for both.
  • A regressionTest.only was temporarily added to the new test loop, which should be removed before merging.

Activity

• The pull request was created by 1307-Dev.
• It addresses GitHub Issue IxInput form submit on enter doesn't work when the submit button is an IxButton #2362 and JIRA Issue IX-3895, aiming to fix form submission behavior for ix-button elements.
• The author has confirmed that unit tests pass, static code analysis passes, and compilation is successful.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a hotfix to ensure forms are submitted on 'Enter' key press when an ix-button with type="submit" is used. The changes involve updating the handleSubmitOnEnterKeydown utility function and expanding the test suite to cover this new scenario.

The changes are generally good and address the issue described. The following comments have been retained as they are valid and do not conflict with the provided rules:

• A suggestion to simplify the logic in input.util.ts by removing what appears to be a redundant code block, which would improve maintainability.
• A request to remove .only from the new test case in form-ready.ct.ts to ensure all tests are executed in the test suite.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud