[WIP] Calendars export to other devices (issue#824)#102
Open
Seal98 wants to merge 12 commits intosigmah-dev:masterfrom
Open
[WIP] Calendars export to other devices (issue#824)#102Seal98 wants to merge 12 commits intosigmah-dev:masterfrom
Seal98 wants to merge 12 commits intosigmah-dev:masterfrom
Conversation
Creating a servlet for making a subscription to the URL
Creating share buttons with a popup window with the URL after its pushing
Implemented: -Added showing share calendar events URL with parameters: event type and project id -Added tool tips to share calendar buttons -Export servlet is renamed to ExportCalendar -Added fetching calendar events by the servlet for specified project id. -Added generation by servlet iCal output with Sigmah calendar events.
Performed refactoring and code cleanup.
Performed refactoring and code cleanup according Codacy review remarks
Looltip for each button was changed. The functional for the events button works
Member
|
Hi @Seal98, Great to see so much work on this issue #824 ! Looking forward to the demo tomorrow !
See you tomorrow ! |
Added possibility to update(refresh) in Outlook imported by URL Sigmah calendar with defined in ExportCalendar servler time interval. Added name to imported calendar.
Added methods to get from Request User-agent and ip info for logging to see who calls ExportCalendar servlet.
-Method getClientIpAddr is refactored to comply with Codacy check. -IndexedDB fix to allow run Sigmah online is applied.
Hiding all Share-link buttons except the 'events' button
-Implemented URL parameter values encryption when URL is created. -Implemented URL parameter values decryption when URL is processed by export calendar servlet. -Made the URL look like a filename ending with ".ics"
-Added to Set to export calendar events Time Zone, Publish, Organizer. -Performed code changes according Codacy code check.
|
At first sight, this can't be merged without a global clean-up (altered license headers, personal settings in pom.xml, offline mode disabled...). |
Member
|
Thanks @numero-six for this review ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a servlet that allows external programs to subscribe to the Sigmah calendar using URL