0000619: Add year in Indicators export monthly table#16
0000619: Add year in Indicators export monthly table#16manishvishnoi2 wants to merge 2 commits intosigmah-dev:masterfrom manishvishnoi2:0000619
Conversation
| int rowIndex = -1; | ||
|
|
||
| final List<PivotTableData.Axis> leaves = data.getEntryMap().get(indicator.getId()).getRootColumn().getLeaves(); | ||
| final List<PivotTableData.Axis> leavesyear=data.getEntryMap().get(indicator.getId()+1).getRootColumn().getLeaves(); |
There was a problem hiding this comment.
@manishvishnoi2 : This needs an indentation fix before the pull request can be merged.
|
hello @spMohanty : After using format tool given by Netbeans on all of my code,the above changes were recorded.Please take a look and if those are not ok, Suggest me a method to perform correct formatting. |
| month = 10; | ||
| } else if (completedate.equals("Nov")) { | ||
| month = 11; | ||
| } else { |
There was a problem hiding this comment.
Please do it more safely, like
} else if (completeDate.equals("Dec")) {
month = 12;
} else {
throw new IllegalStateException("unable to parse " + completedate);
}There was a problem hiding this comment.
Also, it's quite strange you do that manually, you should be using a date manipulation API (I guess, something like java.text.DateFormat).
|
It seems that some code have been copy-pasted from |
| month = 1; | ||
| } else { | ||
| month++; | ||
| } |
There was a problem hiding this comment.
A date manipulation API should do that kind of thing for you. You may have a look at something called lenient (see java.text.DateFormat#setLenient for example)
2 participants
Fixes 0000619 .
Example Screenshot :
Project_synthesis_20160311235041.xls.zip