Skip to content

ci: migrate to OIDC trusted publishing#10

Merged
aose-yuu merged 2 commits into
mainfrom
ci/oidc-trusted-publishing
Dec 19, 2025
Merged

ci: migrate to OIDC trusted publishing#10
aose-yuu merged 2 commits into
mainfrom
ci/oidc-trusted-publishing

Conversation

@aose-yuu
Copy link
Copy Markdown
Contributor

CI/CDをOIDC Trusted Publishingに移行し、workflowを最小化します。\n\n- .github/workflows を ci.yml / publish.yml に整理\n- npm publish は OIDC (id-token) で実行し、NPM_TOKEN を不要に\n- squash merge 前提で PR title を Conventional 形式に検証\n

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +44 to +46
- name: npm publish (OIDC trusted publishing)
if: steps.npmcheck.outputs.published != 'true'
run: npm publish --access public
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge npm publish runs without authentication

The new publish workflow removes NODE_AUTH_TOKEN but the publish step now calls npm publish --access public without enabling provenance (--provenance/NPM_CONFIG_PROVENANCE) or any other authentication. npm only uses GitHub’s OIDC flow when provenance is requested; otherwise it expects an auth token and exits with EAUTH/ENEEDAUTH. On any tag push this step will fail before releasing the package, blocking trusted publishing entirely.

Useful? React with 👍 / 👎.

@aose-yuu aose-yuu merged commit 2f03cad into main Dec 19, 2025
2 checks passed
@aose-yuu aose-yuu deleted the ci/oidc-trusted-publishing branch December 19, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant