add additional env variables to fulcio chart#790
add additional env variables to fulcio chart#790Racer159 wants to merge 6 commits intosigstore:mainfrom
Conversation
dbd368c to
674cab3
Compare
|
On this though would it make sense to use a pattern more similar to Rekor for extra env vars? https://github.com/sigstore/helm-charts/blob/main/charts/rekor/templates/server/deployment.yaml#L105 - it may be nice in many cases to pull env vars from secrets rather than pass them through Helm values. (i.e. |
674cab3 to
de59237
Compare
Support GCP credentials for external cloud provider workloads Co-authored-by: saisatish karra <saisatish.karra@konghq.com> Signed-off-by: Wayne Starr <me@racer159.com>
Co-authored-by: saisatish karra <saisatish.karra@konghq.com> Signed-off-by: Wayne Starr <me@racer159.com>
Co-authored-by: saisatish karra <saisatish.karra@konghq.com> Signed-off-by: Wayne Starr <me@racer159.com>
Co-authored-by: saisatish karra <saisatish.karra@konghq.com> Signed-off-by: Wayne Starr <me@racer159.com>
Signed-off-by: Wayne Starr <me@racer159.com>
Signed-off-by: Wayne Starr <me@racer159.com>
de59237 to
a2f7ddf
Compare
|
(would also like to make a similar change to the |
|
How do I vote up on this. Fulcio needs to set envs to get client_id and secret. Or can I pick up this somehow |
Description of the change
Support GCP credentials for external cloud provider workloads and add additional env vars for specifying values like
VAULT_ADDRExisting or Associated Issue(s)
This is a repickup of #530
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.