-
Notifications
You must be signed in to change notification settings - Fork 758
Description
Describe the bug
Crucible of Erratic Energies (item 264507) never procs for melee specs. The driver spell (1272091) has
proc_flags=0x00015500, which contains no melee proc types. When the proc callback is initialized, it registers only
for those proc types, meaning melee actions never trigger the callback at all. The SX_ONLY_PROC_FROM_CLASS_ABILITIES
check inside trigger() is never reached for melee actions because the dispatch filter eliminates them first.
Expected behavior
The trinket should proc from class abilities for melee specs. In-game testing confirms it does proc live from specific
class abilities but not from auto-attacks. This suggests the live engine may handle
SX_ONLY_PROC_FROM_CLASS_ABILITIES differently than simc — possibly by broadening proc eligibility beyond what
proc_flags alone would allow — but the exact live behavior is not fully confirmed.
To Reproduce
Sim any melee spec with Crucible of Erratic Energies equipped. Enable debug logging and search for voidlust
Additional information
- SimulationCraft Version: 1201.01
The original bug report diagnosis (proc_flags are wrong) is incorrect. wago.tools confirms ProcTypeMask=0x00015500
on spell 1272091. simc is reading the correct game data.
- simc does implement SX_ONLY_PROC_FROM_CLASS_ABILITIES (spell_attribute index 415, maps to SPELL_ATTR12 bit 31 =
0x80000000). The check exists in dbc_proc_callback_t::trigger() at line 210, but is never reached for melee actions. - Several class modules hardcode allow_class_ability_procs = true on auto-attacks (warrior, rogue, monk, dk, dh,
druid, shaman, paladin, hunter). If the registration issue is fixed, these would cause auto-attacks to incorrectly
proc Crucible — live testing shows auto-attacks do not proc it.