Fix StaticUnion regression for non-tuple Array<TSchema>#1598
Open
jackyzha0 wants to merge 1 commit into
Open
Conversation
In typebox 0.34, UnionStatic used a mapped-index-signature pattern
`{[K in keyof T]: Static<T[K]>}[number]` that resolved correctly for
both tuple types and general `TSchema[]` arrays.
In 1.x, StaticUnion was rewritten using head/tail destructuring with a
`Result = never` default. Because `TSchema[]` does not match
`[Left, ...Right]` (the array may be empty), `Static<TUnion<TSchema[]>>`
falls through to `never`. This regresses any code that builds a union
from a variable typed as a plain array:
const errors = [Type.Object(...), Type.Object(...)];
const schema = Type.Union(errors);
type T = Static<typeof schema>; // resolves to `never` instead of the union
Fix: add an `Array<infer Item extends TSchema>` fallback that infers the
element type when the input is not a tuple. Tuples still go through the
fast recursive path; the new branch only fires for general arrays.
Adds static tests covering:
- inline tuple inference (existing behaviour)
- generic TSchema[] (must not resolve to never)
- narrowed Array<TLiteral<1|2|3>> (must resolve to 1|2|3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In typebox 0.34, UnionStatic used a mapped-index-signature pattern
{[K in keyof T]: Static<T[K]>}[number]that resolved correctly for both tuple types and generalTSchema[]arrays.In 1.x, StaticUnion was rewritten using head/tail destructuring with a
Result = neverdefault. BecauseTSchema[]does not match[Left, ...Right](the array may be empty),Static<TUnion<TSchema[]>>falls through tonever. This regresses any code that builds a union from a variable typed as a plain array:Fix: add an
Array<infer Item extends TSchema>fallback that infers the element type when the input is not a tuple. Tuples still go through the fast recursive path; the new branch only fires for general arrays.Adds static tests covering: