Skip to content

Show an alert when trying to assign a shortcut that’s already in use. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kdaniel123 wants to merge 2 commits into from
Closed

Show an alert when trying to assign a shortcut that’s already in use. #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d0a46f
Show an alert when trying to assign a shortcut that’s already in use.
Jul 11, 2025
7d04a42
Revert text change
Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/KeyboardShortcuts/KeyboardShortcuts.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,9 @@

private static func handleOnKeyDown(_ shortcut: Shortcut) {
guard !isPaused else {
NSAlert.showModal(
for: nil,
title: "keyboard_shortcut_used_by_other_action".localized)

Check warning on line 386 in Sources/KeyboardShortcuts/KeyboardShortcuts.swift

View workflow job for this annotation

GitHub Actions / lint 

Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
return
}

Expand All @@ -407,6 +410,9 @@

private static func handleOnKeyUp(_ shortcut: Shortcut) {
guard !isPaused else {
NSAlert.showModal(
for: nil,
title: "keyboard_shortcut_used_by_other_action".localized)

Check warning on line 415 in Sources/KeyboardShortcuts/KeyboardShortcuts.swift

View workflow job for this annotation

GitHub Actions / lint 

Multiline Arguments Brackets Violation: Multiline arguments should have their surrounding brackets in a new line (multiline_arguments_brackets)
return
}

Expand Down
1 change: 1 addition & 0 deletions Sources/KeyboardShortcuts/Localization/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"record_shortcut" = "Record Shortcut";
"press_shortcut" = "Press Shortcut";
"keyboard_shortcut_used_by_other_action" = "This keyboard shortcut is already assigned to another action."
"keyboard_shortcut_used_by_menu_item" = "This keyboard shortcut cannot be used as it’s already used by the “%@” menu item.";
"keyboard_shortcut_used_by_system" = "This keyboard shortcut cannot be used as it’s already a system-wide keyboard shortcut.";
"keyboard_shortcuts_can_be_changed" = "Most system-wide keyboard shortcuts can be changed in “System Settings › Keyboard › Keyboard Shortcuts”.";
Expand Down