Replace invalid characters with a placeholder#105
Open
JohnFinn000 wants to merge 1 commit intosj26:mainfrom
Open
Replace invalid characters with a placeholder#105JohnFinn000 wants to merge 1 commit intosj26:mainfrom
JohnFinn000 wants to merge 1 commit intosj26:mainfrom
Conversation
|
This would be useful 👍🏼 |
|
Tested this on our CI, fixed similar error with invalid XML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that when tests print an emoji in the failure reason rspec_junit_formatter fails and prints the xml its already generated to that point which ends up being invalid because it creates an xml element with a missing closing brackets and that cannot be parsed by the tools that attempt to read it.
This fix causes invalid characters to be replaced with ??invalid?? instead of bailing out immediately. rspec_junit_formatter shouldn't output invalid xml regardless of the failures it encounters along the way.
This should fix this issue: #92