Feature: Specifying source for undo / redo#4570
Open
hectoreccles wants to merge 2 commits intoslab:mainfrom
Open
Feature: Specifying source for undo / redo#4570hectoreccles wants to merge 2 commits intoslab:mainfrom
hectoreccles wants to merge 2 commits intoslab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the undo/redo methods to allow you to specify a source. The following changes were made:
changemethod fromsourceanddesttosourceStackanddestStack.sourceparameter for thechangemethod with theEmitterSourcetype.undoandredomethods to leverage the updatedchangemethod while maintaining backward compatibility.Motivation
These changes make the undo/redo methods more flexible, particularly in cases where you want to undo or redo actions while user interaction is disabled.
Testing
Please review the changes and let me know if any adjustments are needed. Also this is my first ever PR so apologizes if I have done anything wrong.