Skip to content

Feature: Specifying source for undo / redo#4570

Open
hectoreccles wants to merge 2 commits intoslab:mainfrom
hectoreccles:feature/undo-redo-improvements
Open

Feature: Specifying source for undo / redo#4570
hectoreccles wants to merge 2 commits intoslab:mainfrom
hectoreccles:feature/undo-redo-improvements

Conversation

@hectoreccles
Copy link

Summary

This pull request refactors the undo/redo methods to allow you to specify a source. The following changes were made:

  • Renamed parameters for the change method from source and dest to sourceStack and destStack.
  • Added new source parameter for the change method with the EmitterSource type.
  • Refactored undo and redo methods to leverage the updated change method while maintaining backward compatibility.

Motivation

These changes make the undo/redo methods more flexible, particularly in cases where you want to undo or redo actions while user interaction is disabled.

Testing

  • Verified that undo/redo functionality behaves as expected in the editor.
  • Confirmed backward compatibility with existing workflows.

Please review the changes and let me know if any adjustments are needed. Also this is my first ever PR so apologizes if I have done anything wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant