feat: add team.externalTeams.list#1512
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
==========================================
- Coverage 85.04% 84.88% -0.16%
==========================================
Files 112 112
Lines 12440 12473 +33
==========================================
+ Hits 10579 10588 +9
- Misses 1861 1885 +24 ☔ View full report in Codecov by Sentry. |
filmaj
left a comment
There was a problem hiding this comment.
LGTM but let's hold off on merging until the API goes public.
seratch
left a comment
There was a problem hiding this comment.
Thanks for working on it! It seems the endpoint is not yet public. Let's hold off merging this PR until the API becomes publicly available.
| @@ -17,7 +17,7 @@ | |||
| class TestWebClientCoverage(unittest.TestCase): | |||
| # 284 endpoints as of June 12, 2024 | |||
| # Can be fetched by running `var methodNames = [].slice.call(document.getElementsByClassName('apiReferenceFilterableList__listItemLink')).map(e => e.href.replace("https://api.slack.com/methods/", ""));console.log(methodNames.toString());console.log(methodNames.length);` on https://api.slack.com/methods | |||
There was a problem hiding this comment.
The list of methods is the output by this JS script. "team.externalTeams.list" is not yet public, so let's hold off making the manual change here until it becomes public.
There was a problem hiding this comment.
Sounds good 👍
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
|
@WilliamBergamin this API is now live, so when ready, we should merge and release. |
|
If you have the bandwidth, adding an integration tests for this API call is a great addition for safety and future maintenance (but it's optional) |
Summary
This PR implements the team.externalTeams.list method for the python clients
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.