Skip to content

Docs: remove line breaks in md intros for unfurls#1538

Merged
lukegalbraithrussell merged 2 commits intomainfrom
docs-luke-unfurl-text
Aug 6, 2024
Merged

Docs: remove line breaks in md intros for unfurls#1538
lukegalbraithrussell merged 2 commits intomainfrom
docs-luke-unfurl-text

Conversation

@lukegalbraithrussell
Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell commented Aug 6, 2024

Summary

The classic code practice of breaking lines at x characters long messed up the unfurls. Removed the line breaks

image

Oh I just noticed the path in this template still says /docs-src so I changed it to /docs in this PR too

Testing

You can run it locally to see that it works, but it works. You can't test unfurls locally though

Category

  • /docs (Documents)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@lukegalbraithrussell lukegalbraithrussell added the docs M-T: Documentation work only label Aug 6, 2024
@codecov
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (54f8e72) to head (7bfda1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
+ Coverage   84.94%   84.97%   +0.03%     
==========================================
  Files         113      113              
  Lines       12498    12498              
==========================================
+ Hits        10616    10620       +4     
+ Misses       1882     1878       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell lukegalbraithrussell merged commit 6a67e7b into main Aug 6, 2024
@lukegalbraithrussell lukegalbraithrussell deleted the docs-luke-unfurl-text branch August 6, 2024 15:12
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs M-T: Documentation work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants