Add interactivity_pointer as trigger_id alias to views.* APIs#1556
Merged
WilliamBergamin merged 2 commits intoslackapi:mainfrom Sep 6, 2024
Merged
Add interactivity_pointer as trigger_id alias to views.* APIs#1556WilliamBergamin merged 2 commits intoslackapi:mainfrom
WilliamBergamin merged 2 commits intoslackapi:mainfrom
Conversation
seratch
commented
Sep 6, 2024
| self, | ||
| *, | ||
| trigger_id: str, | ||
| trigger_id: Optional[str] = None, |
Contributor
Author
There was a problem hiding this comment.
The only way to accept both in Python is to make both optional..
Contributor
There was a problem hiding this comment.
We could add some logic that raises a TypeError if both fields are None but this may not be needed if the API error mentions a missing trigger_id or interactivity_pointer field
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
+ Coverage 84.88% 84.91% +0.02%
==========================================
Files 113 113
Lines 12546 12546
==========================================
+ Hits 10650 10653 +3
+ Misses 1896 1893 -3 ☔ View full report in Codecov by Sentry. |
filmaj
approved these changes
Sep 6, 2024
WilliamBergamin
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
views.open and views.push APIs now accept both trigger_id and interactivity_pointer
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.