chore: update refs to v2.1.0-rc.1#4120
Merged
Merged
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Hayden-IO
approved these changes
Feb 19, 2025
Contributor
Author
|
The effect was not as expected. Main has a different commit hash |
Contributor
Author
|
The only way may be to
|
Collaborator
|
I'm not following what is broken. Can we just tag a release from main and test against that? |
Contributor
Author
We need a tagged release, where the released code's workflows also references workflows and actions at the same tag: the the code within v2.1.0-rc.1 must reference call v2.1.0-rc.1, not main. Under normal situations, you can't do this without overwriting a tag. But we don't have permissions to do that anymore. |
This was referenced Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#label:release v2.1.0-rc.1
Summary
Retrying the release, under a new tag, not rc.0.
The original release steps required doing a force push to update the tag in order to trigger workflow to produce the binaries as release artifacts. But now, repo settings make tags immutable, and I don't have permission to change the settings, so we'll try something different:
Testing Process
presubmits should pass
Checklist