Update android, javaSE & javaEE gradle setup to read version for one file #1764
Merged
JulianKast merged 2 commits intodevelopfrom Nov 16, 2021
Merged
Update android, javaSE & javaEE gradle setup to read version for one file #1764JulianKast merged 2 commits intodevelopfrom
JulianKast merged 2 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1764 +/- ##
=============================================
- Coverage 54.37% 54.37% -0.01%
Complexity 5498 5498
=============================================
Files 562 562
Lines 25466 25466
Branches 3317 3317
=============================================
- Hits 13847 13846 -1
Misses 10360 10360
- Partials 1259 1260 +1
|
JulianKast
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1763
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
This PR updates the gradle setup for android, javaSE & javaEE to read the version from one single file called
VERSIONinstead of having 4 different files that needed to be updated separately.Testing Steps
VERSIONfile to any unique version (like5.3.0_xyzfor example)./gradlew buildfor javaSEJavaSEbinary to maven central stagingBuildConfigand uploaded library still use the old version that was set ingradle.propertiesCLA