Remove cloning the ImageRPC in the clone method for SdlArtwork#1821
Merged
JulianKast merged 3 commits intodevelopfrom Jul 18, 2022
Merged
Remove cloning the ImageRPC in the clone method for SdlArtwork#1821JulianKast merged 3 commits intodevelopfrom
JulianKast merged 3 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1821 +/- ##
==========================================
Coverage 54.05% 54.06%
Complexity 5531 5531
==========================================
Files 562 562
Lines 25809 25809
Branches 3395 3395
==========================================
+ Hits 13952 13954 +2
+ Misses 10585 10584 -1
+ Partials 1272 1271 -1
|
bwmfrisch
approved these changes
Jul 15, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1818
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
Github CI unit test
Core Tests
Tested on Manticore for SDL Core v8.1.0 for Android and Generic_HMI v0.12.0 with SDL Core v8.1.0 for JavaSE
Summary
When cloning a SdlArtwork instance, do not clone the imageRPC object with it. This prevents a case where the user changes the file name but the cached object does not update and the T&G manager uses that outdated information.
Changelog
Bug Fixes
CLA