Skip to content

Add logic to handle RAI response failure#1873

Merged
JulianKast merged 1 commit intodevelopfrom
bugfix/issue_1872_RAI_response_failures
Nov 29, 2023
Merged

Add logic to handle RAI response failure#1873
JulianKast merged 1 commit intodevelopfrom
bugfix/issue_1872_RAI_response_failures

Conversation

@joeygrover
Copy link
Copy Markdown
Member

Fixes #1872

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

N/A

Core Tests

  1. Install base version of Hello SDL (no security)
  2. Change package name and SDL app ID in gradle, sync build
  3. Install modified Hello SDL
  4. Connect to IVI
  5. Observe one of the apps connect and the other properly closes because of a duplicate name error

Core version / branch / commit hash / module tested against: Ford TDK Gen3
HMI name / version / branch / commit hash / module tested against: Ford TDK Gen3

Summary

This PR simply adds a check to make sure theRegisterAppInterface response RPC was successful. In the case that it is not, it will clean the LCM and close the instance. This allows the app to close its service class as well and be prepared for the next connection. While the test is not a real world situation, it shows what will happen during a failure which can occur if the IVI does not unregister the app fast enough during transport switching scenarios (BT to BT & USB to only USB)

Changelog

Bug Fixes
  • Added check for unsuccessful app registration with IVI

CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants