Add logic to handle RAI response failure#1873
Merged
JulianKast merged 1 commit intodevelopfrom Nov 29, 2023
Merged
Conversation
JulianKast
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1872
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
N/A
Core Tests
Core version / branch / commit hash / module tested against: Ford TDK Gen3
HMI name / version / branch / commit hash / module tested against: Ford TDK Gen3
Summary
This PR simply adds a check to make sure the
RegisterAppInterfaceresponse RPC was successful. In the case that it is not, it will clean the LCM and close the instance. This allows the app to close its service class as well and be prepared for the next connection. While the test is not a real world situation, it shows what will happen during a failure which can occur if the IVI does not unregister the app fast enough during transport switching scenarios (BT to BT & USB to only USB)Changelog
Bug Fixes
CLA