I think this fixes the truncated messages issue#34
Open
mike-lawrence wants to merge 3 commits intosmbache:masterfrom
Open
I think this fixes the truncated messages issue#34mike-lawrence wants to merge 3 commits intosmbache:masterfrom
mike-lawrence wants to merge 3 commits intosmbache:masterfrom
Conversation
smbache
reviewed
Feb 20, 2018
| } else if (type == "error") { | ||
| } else { | ||
| message = unlist(args) | ||
| message = paste0(message[1:(length(message)-3)],collapse='') |
Owner
There was a problem hiding this comment.
Can we be sure that length(message) > 3 here? We should use consistent syntax, <- for assignment, and spacing in argument list and around the minus.
Owner
|
Thanks for digging into this. I left a few comments in the code section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fixes the truncated messages issue (#33). Maybe double-check that my tossing of the last three entries in
argsdoesn't have any unwanted effects that I'm not considering?