Inline directly the default transparentImage#13
Open
dcorb wants to merge 1 commit intosmurfy:masterfrom
Open
Conversation
Owner
|
Thank you, and you are half correct. Version 1.0.2 (which this fork is based on) had the "." as default. Which apparently the 1.0.3 fixes by providing a blank.gif So i added the That said. It makes sense to change the default, because the default is stupid :) |
Author
|
Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great work. Maybe you consider this useful.
The default option "." results in a ajax request that most probably is a 404 page or HTML page.
Provide a useful and not broken experience by default. Specially for users who are using this library as drop-in-replacement, since then "transparentImage" was not part of the original library.
In our case, we use the library through https://www.drupal.org/project/cloud_zoom, so we can't access the original plugin js initialisation options.
Thanks