Skip to content

fix(typings): accept an Http2Server non-secure as http-server instance#4853

Merged
darrachequesne merged 3 commits into
socketio:mainfrom
0x0a0d:fix-typing
Nov 22, 2023
Merged

fix(typings): accept an Http2Server non-secure as http-server instance#4853
darrachequesne merged 3 commits into
socketio:mainfrom
0x0a0d:fix-typing

Conversation

@0x0a0d

@0x0a0d 0x0a0d commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

http server should accept non-secure http2server instance

@darrachequesne

Copy link
Copy Markdown
Member

Hi! Out of curiosity, what is your use case? (since there are no browsers known that support unencrypted HTTP/2)

@0x0a0d

0x0a0d commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

We can use it not only on browser but also on server to server that don't require TLS due to performance

@darrachequesne darrachequesne merged commit 8c9ebc3 into socketio:main Nov 22, 2023
@darrachequesne

Copy link
Copy Markdown
Member

@0x0a0d thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants