Fix race condition between C_FindObjects and object creation (issue 573)#576
Merged
Fix race condition between C_FindObjects and object creation (issue 573)#576
Conversation
Closed
Fix indenting
Contributor
|
I've put a generic "flush before unlock" into File in #578, because none of the buffered reads or writes are flushed before unlocking, so the call to flush() will become unnecessary here. |
Contributor
Author
|
@nomis thanks for #578 and this note, I will wait for feedback from @ionut-arm and merge both PRs after positive feedback. |
|
Thanks for the change! Ionut will come back on Wednesday 16th. The changes look as planned so I am sure it would be fine to merge if you wanted to do that earlier 😃 |
|
Hi! Apologies for the delay - I've tested again and it seems the stress test still fails, but while before it was failing mainly with |
Removed `flush()` that will become unnecessary when #578 is merged.
|
Hey! Sorry for such a late reply, I managed to do some checks both locally and in the CI and it seems the latest change fixes our problems! 🎉 If you're ok with it, we're all in for it to be merged. |
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
ionut-arm
added a commit
to ionut-arm/parsec
that referenced
this pull request
Oct 22, 2020
This commit removes the mutex that was used to force the PKCS11 provider to work in a single-threaded way. The issue was fixed in softhsm/SoftHSMv2#576 and our Dockerfiles have been updated to use that commit. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This likely fixes #573