Switch to rails 5 spec keyword request syntax#80
Merged
Conversation
This adds the rails_test_params_backport gem which allows us to write requests in specs using the :params, :headers and :env options introduced in Rails 5. This allows the same specs to run on both rails 4.2 and rails 5 without generating deprecation warnings.
jhawthorn
changed the title
stewart
approved these changes
Feb 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
rails_test_params_backportgem which allows us to write requests in specs using the:params,:headersand:envoptions introduced in Rails 5.This allows the same specs to run on both rails 4.2 and rails 5 without generating deprecation warnings.