Use the tag attribute for getting the modelClass and use the argument…#630
Merged
Conversation
… only as fallback. Because passing the code, the model class and the controller name as arguments has been deprecated in SonataAdmin 4.8.0. Fixes #628
- add foreach for looping the tags
VincentLanglet
approved these changes
Mar 22, 2022
jordisala1991
requested changes
Mar 22, 2022
Member
There was a problem hiding this comment.
You should change the constraint to admin-bundle in the composer.json to atleast 4.8
https://github.com/sonata-project/SonataTranslationBundle/blob/3.x/composer.json#L24
Member
Why ? There is a |
jordisala1991
approved these changes
Mar 22, 2022
jordisala1991
left a comment
jordisala1991
left a comment
Member
There was a problem hiding this comment.
You're right, there is no need to up the version constraint :)
Member
|
Thank you @fransweerts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… only as fallback.
Because passing the code, the model class and the controller name as arguments has been deprecated in SonataAdmin 4.8.0.
Fixes #628
Subject
I am targeting this branch, because it fixes deprecation notices.
Closes #628.
Changelog