Skip to content

[fast/warm-reboot] Retain TRANSCEIVER_INFO tables on fast/warm-reboot#3240

Merged
prgeor merged 2 commits into
sonic-net:masterfrom
stepanblyschak:retain-transceiver-tables
Apr 19, 2024
Merged

[fast/warm-reboot] Retain TRANSCEIVER_INFO tables on fast/warm-reboot#3240
prgeor merged 2 commits into
sonic-net:masterfrom
stepanblyschak:retain-transceiver-tables

Conversation

@stepanblyschak

@stepanblyschak stepanblyschak commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

What I did

Retain TRANSCEIVER_INFO tables on fast/warm reboot. The PHY isn't reset on fast/warm reboot. Knowing about plugged modules is required for orchagent to set SAI_PORT_ATTR_HOST_TX_SIGNAL_ENABLE=true on start.

How I did it

Save TRANSCEIVER_INFO tables on warm/fast-reboot.

How to verify it

Run fast/warm-reboot.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@prgeor

prgeor commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

@mihirpat1 @vaibhavhd please review

Comment thread scripts/fast-reboot Outdated
and not string.match(k, 'FG_ROUTE_TABLE|') \
and not string.match(k, 'WARM_RESTART_ENABLE_TABLE|') \
and not string.match(k, 'TRANSCEIVER_INFO|') \
and not string.match(k, 'TRANSCEIVER_STATUS|') \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stepanblyschak OA subscribes to TRANSCEIVER_INFO, why save TRANSCIEVER_STATUS?

@prgeor prgeor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stepanblyschak As discussed offline, lets fix your platform API so that Xcvrd can identify already present transceivers.

@stepanblyschak stepanblyschak changed the title [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on fast/warm-reboot [fast/warm-reboot] Retain TRANSCEIVER_INFO tables on fast/warm-reboot Apr 15, 2024
@stepanblyschak

Copy link
Copy Markdown
Contributor Author

@prgeor removed TRANSCEIVER_STATUS

@prgeor prgeor merged commit 07d6d27 into sonic-net:master Apr 19, 2024
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request May 13, 2024
…sonic-net#3240)

* [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

* Remove TRANSCEIVER_STATUS

---------

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202311: #3319

mssonicbld pushed a commit that referenced this pull request May 13, 2024
…#3240)

* [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

* Remove TRANSCEIVER_STATUS

---------

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
…sonic-net#3240)

* [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

* Remove TRANSCEIVER_STATUS

---------

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
…sonic-net#3240)

* [fast/warm-reboot] Retain TRANSCEIVER_INFO/STATUS tables on reboot

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

* Remove TRANSCEIVER_STATUS

---------

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants