Conversation
- Fixed go test ./... - Update golang.org/x/tools from v0.17.0 to v0.37.0 - Update bytedance/sonic from v1.12.5 to v1.14.1 to fix Go 1.24+ compatibility - Fix non-constant format string issues in tests - Upgrade to Go 1.24.1 (required for sonic v1.14.1 compatibility)
varungandhi-src
approved these changes
Sep 29, 2025
Contributor
varungandhi-src
left a comment
varungandhi-src
left a comment
There was a problem hiding this comment.
I think this is fine, but generally we support 2 major Go versions, so I think we shouldn't bump beyond this until Go 1.27 is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
go test ./...on main ends up with the following error:This was fixed mainly by updating
golang.org/x/tools.We explicitly require go v1.24.1 (instead of v1.24.0) because of Sonic requirement.
Test plan
N/A