Conversation
added 2 commits
December 6, 2024 07:09
Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
…ct logic Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
vdavid
approved these changes
Dec 6, 2024
Contributor
vdavid
left a comment
vdavid
left a comment
There was a problem hiding this comment.
Both changes make sense. I'm AFK but went through all the code on mobile, and they look good. Approving to unblock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit here replaces the authentication with a simpler / more correct implementation (no transport) and improves usage doc commands slightly.
The second commit fixes a major issue: we would connect the websocket at the very start, which meant that if the tests which run before we use the websocket take >60s.. by the time we use the websocket, the server would already consider the connection dead due to inactivity. This fixes the issue by only connecting the first time we want to use the connection, and also adding reconnect logic.
Test plan
Manually tested