Fix progress bar when previously printed text has color#247
Merged
Conversation
ryanslade
approved these changes
Jul 13, 2020
eseliger
approved these changes
Jul 13, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Remove unused dependency in ActionLogger * Fix typo * Show progress bar even when printed text has color
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change in a previous PR broke the display of the progress bar:
https://github.com/sourcegraph/src-cli/pull/236/files#diff-f88fc84c78d26d5dc5fde4a5223bc866L258
Why did it break? Because the "display progress bar?"-check checked whether the just-printed data ended in a newline or not. That worked until the just mentioned change, after which every line was wrapped in "set color" and "reset color" escape codes. They wouldn't end in
\nbut in\n\x1b[0m.The new check fixes the progress bar.
The other two commits fix a typo and remove an unused dependency.