api: pass in body to NewRequestWithContext#263
Merged
Conversation
By directly passing in the body we will also get the ContentLength header set. Minor: we avoid the extra buffer than json.NewEncoder uses, and isntead directly get the buffer from json.Marshal.
LawnGnome
approved these changes
Aug 14, 2020
LawnGnome
left a comment
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
I like it! The perils of copy/pasting blindly when refactoring.
Thanks! 👍
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
By directly passing in the body we will also get the ContentLength header set. Minor: we avoid the extra buffer than json.NewEncoder uses, and instead directly get the buffer from json.Marshal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By directly passing in the body we will also get the ContentLength
header set.
Minor: we avoid the extra buffer than json.NewEncoder uses, and isntead
directly get the buffer from json.Marshal.