Use new API to resolve workspaces server-side#801
Merged
Conversation
eseliger
commented
Jul 15, 2022
# Conflicts: # go.mod # go.sum
eseliger
commented
Jul 15, 2022
Comment on lines
+251
to
+257
| if unsupported.HasUnsupported() { | ||
| return workspaces, repos, unsupported | ||
| } | ||
|
|
||
| if ignored.HasIgnored() { | ||
| return workspaces, repos, ignored | ||
| } |
Member
Author
There was a problem hiding this comment.
This just mimics what we currently do here. This deserves a refactor, too, but not in this PR :)
BolajiOlajide
approved these changes
Jul 15, 2022
LawnGnome
approved these changes
Jul 15, 2022
LawnGnome
left a comment
LawnGnome
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
In terms of src batch repos: yeah, given that was a pre-workspaces "eh, seems useful" thing, we should rethink that. Maybe we add a new src batch workspaces and make src batch repos a deprecated command that just does that with a message saying it's deprecated?
Piszmog
approved these changes
Jul 18, 2022
courier-new
approved these changes
Jul 19, 2022
courier-new
left a comment
courier-new
left a comment
Contributor
There was a problem hiding this comment.
Agreed with your proposition and Adam's comment -- we can mark src batch repos as deprecated for now while we retain the old code path and have the proper resolution for src batch workspaces instead.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Makes use of the newly introduced endpoint in src-cli. This is usually faster, and it means we can eventually have just one code path again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use of the newly introduced endpoint in src-cli. This is usually faster, and it means we can eventually have just one code path again.
I think this is good as-is and a net-improvement that we should get in, but before we can remove the old code path, we should have a conversation about the
src batch reposcommand:on:sectionHence I propose that we shift this to run a proper workspace resolution and just print that outcome, like we do in the UI.
Closes https://github.com/sourcegraph/sourcegraph/issues/36261
Test plan
Validated everything works as expected.