-
Notifications
You must be signed in to change notification settings - Fork 70
src doc: add code-intel and remove lsif #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@LawnGnome testing this locally in |
| "extensions": &extensionsCommands, | ||
| "extsvc": &extsvcCommands, | ||
| "lsif": &lsifCommands, | ||
| "code-intel": &codeintelCommands, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to keep supporting src lsif but hide it from -help? I'm not convinced this backwards breaking change is worth it because it punishes to customers who have gone through the effort of setting up precise intel in their CI pipelines. We only introduced src code-intel a few months ago, I'd expect the deprecation cycle to last at least 1-2 years for an enterprise product like our and I honestly think it's fine to support src lsif forever as long as it doesn't cause a maintenance burden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
olafurpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I thought this PR removed the actual command itself.
Turns out this is not an issue. I only ran into this because I didn't run the |
varungandhi-src
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!

See this Slack thread.
Test plan