snapshot: add pg_dump command builder with 'snapshot databases'#889
Merged
Conversation
bobheadxi
force-pushed
the
src-snapshot-pgdump-templater
branch
from
383677c to
e7a1e42
Compare
Closed
michaellzc
reviewed
Nov 26, 2022
michaellzc
reviewed
Nov 26, 2022
Co-authored-by: Michael Lin <mlzc@hey.com>
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
michaellzc
approved these changes
Nov 28, 2022
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Add simple utility for generating commands that can then be run/modified to create database dumps. Right now, it's mostly for reference - as we build experience with different setups we can see if this can be made more flexible in the right ways. I believe a templating command like this is important to have, however, since we want to make sure all databases are exported and the correct flags are used with pg_dump, and documentation + manual copy-paste is error-prone. Co-authored-by: Michael Lin <mlzc@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add simple utility for generating commands that can then be run/modified to create database dumps.
Right now, it's mostly for reference - as we build experience with different setups we can see if this can be made more flexible in the right ways. I believe a templating command like this is important to have, however, since we want to make sure all databases are exported and the correct flags are used with
pg_dump, and documentation + manual copy-paste is error-prone.Closes https://github.com/sourcegraph/customer/issues/1611 for now.
Test plan
Also tested the kubectl commands on k8s.sgdev.org