Validate: no longer require SRC_GITHUB_TOKEN to be set #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scjohns
reviewed
Mar 15, 2023
Contributor
scjohns
left a comment
scjohns
left a comment
There was a problem hiding this comment.
LGTM, but I don't write Go code so would be great to have someone more familiar with the code give the approval
eseliger
approved these changes
Mar 15, 2023
Member
eseliger
left a comment
eseliger
left a comment
There was a problem hiding this comment.
did a quick glance, nothing stood out so let's go :)
jdpleiness
force-pushed
the
jdp/fix-src-github-token
branch
from
cfaa7a3 to
e3d07b8
Compare
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
src validate installrequired the env varSRC_GITHUB_TOKENto be set, even if no external services were being added. This also blocked validating queries with repositories that already existed on a Sourcegraph deployment.This fix allows
src validate installto be run without requiring theSRC_GITHUB_TOKENenv var to be set, as well as validating queries with repositories that already exist on a deployment.Fixes #956
Fixes https://github.com/sourcegraph/sourcegraph/issues/47576
Test plan
Locally tested changes using latest Sourcegraph Helm install.
ran go test ./... - all tests passing
ran staticcheck ./... - no issues found in new code