Fix default group and dir-group for RHEL-derived linux config#153
Fix default group and dir-group for RHEL-derived linux config#153bish0polis wants to merge 10 commits intosous-chefs:mainfrom
Conversation
--author "anonymous gdpr@example.com"
Enhance imfile template management See merge request automation/rsyslog!1
- Remove remote.conf when no more remote servers
6.0.10 (2019-03-08) See merge request automation/rsyslog!2
|
@bish0polis thanks for the fix! can you pls fix code style violations so this may be merged? |
by-hand indentation
|
Closing due to inactivity. If this is still wanted please reopen or open another pull request. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, |
|
It doesn't appear I can re-open it. But if it sat for 20 months in a ready state, I don't know what re-opening's going to do. |
|
Re-opening means there is still a desire for this feature, when we inherit cookbooks some older prs are no longer valid, this is a way of finding out features wanted/required vs features no longer wanted |
xorima
added
the
Release: Minor
Neat. I couldn't find the bit on the UI that allowed for re-opening. Either I'm used to GL vs GH or an ACL prevented its inclusion. |
| owner node['rsyslog']['user'] | ||
| group node['rsyslog']['group'] |
There was a problem hiding this comment.
Hey @bish0polis
Taking another look at this these would be much better as properties on the resource which default to these values for now.
Thanks
ramereth
added
the
Waiting on Contributor
4 participants
Description
This change fixes the issue in #152
Issues Resolved
#152
Note
This patch is hereby public domain. I committed without standing on the left foot, or including the right magic legal statement, or whatever voodoo is required; and I don't have the gear to prove adequate testing. And after midnight the additional costs of donated labour start to become noticeable. :-/