draft DHCP allocator abstraction#132
Draft
soypat wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 59.17% 59.28% +0.10%
==========================================
Files 104 106 +2
Lines 11664 11813 +149
==========================================
+ Hits 6902 7003 +101
- Misses 4041 4074 +33
- Partials 721 736 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Quickly glanced over it and already found a couple questionable items in this PR. Want me to review or rather wait until you moved it out of draft? |
Owner
Author
|
As you wish, this PR is pure clankerspeak. I'll eventually take a more in depth look, just wanted to get it out there so I could see diff comfortably |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing tinygo-org/espradio#51 (comment)