Use use for all functions for those free extra nanoseconds#25
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes calls to global PHP functions/constants by importing them with use function / use const, avoiding fully-qualified references and namespace fallback resolution in the library and its tests.
Changes:
- Import frequently used global PHP functions in test files (
session_*,sprintf,urlencode). - Import global PHP functions/constants in
src/PhpInfo.phpand switch default flags from\INFO_ALLtoINFO_ALLviause const INFO_ALL. - Import global functions in
src/SensitiveValueSanitizer.phpand switch\session_name()tosession_name()viause function session_name.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SensitiveValueSanitizerTest.phpt | Adds use function imports for session and string helpers used in the test. |
| tests/SensitiveValueSanitizerNoSessionTest.phpt | Adds use function imports for session_name, sprintf, and urlencode. |
| tests/PhpInfoTest.phpt | Adds use function imports for session helpers used in setup/teardown. |
| src/SensitiveValueSanitizer.php | Imports global helpers and uses imported session_name() instead of \session_name(). |
| src/PhpInfo.php | Imports global output/string helpers and INFO_ALL, then uses INFO_ALL as the default flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.