Skip to content

Remove redundant explain settings ctor#1534

Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom
gitfool:gh1532
Apr 27, 2024
Merged

Remove redundant explain settings ctor#1534
patriksvensson merged 1 commit intospectreconsole:mainfrom
gitfool:gh1532

Conversation

@gitfool
Copy link
Contributor

@gitfool gitfool commented Apr 26, 2024

Fixes #1532.

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Removed the explain settings ctor and added property setters.


Please upvote 👍 this pull request if you are interested in it.

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patriksvensson patriksvensson merged commit b1b50a2 into spectreconsole:main Apr 27, 2024
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@gitfool gitfool deleted the gh1532 branch April 27, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExplainCommand+Settings ctor fails ServiceProvider.ValidateService

2 participants