Skip to content

Comments

Trimming of TestConsole output by CommandAppTester is user configurable.#1739

Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom
FrankRay78:1738-CommandAppTester-is-trimming-TestConsole-output
Jan 21, 2025
Merged

Trimming of TestConsole output by CommandAppTester is user configurable.#1739
patriksvensson merged 1 commit intospectreconsole:mainfrom
FrankRay78:1738-CommandAppTester-is-trimming-TestConsole-output

Conversation

@FrankRay78
Copy link
Contributor

fixes #1738. CommandAppTester is trimming TestConsole output, requiring expected outputs to be manually adjusted

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Trimming of TestConsole output by CommandAppTester is user configurable.

CommandAppTester now accepts a CommandAppTesterSettings class, containing the TrimConsoleOutput property.

TrimConsoleOutput defaults to true, preserving existing behaviour and ensuring the change is backward compatible.


Please upvote 👍 this pull request if you are interested in it.

@FrankRay78 FrankRay78 self-assigned this Jan 21, 2025
@FrankRay78 FrankRay78 added the area-Testing-Framework Spectre.Console testing framework for developers. label Jan 21, 2025
@FrankRay78 FrankRay78 added this to the 0.50 milestone Jan 21, 2025
@patriksvensson patriksvensson merged commit f704f2a into spectreconsole:main Jan 21, 2025
3 checks passed
@FrankRay78
Copy link
Contributor Author

Many thanks @patriksvensson

@FrankRay78 FrankRay78 deleted the 1738-CommandAppTester-is-trimming-TestConsole-output branch February 10, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Testing-Framework Spectre.Console testing framework for developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CommandAppTester is trimming TestConsole output, requiring expected outputs to be manually adjusted

2 participants