Refactor lib/ for idiomatic, terse Ruby#2
Merged
nateberkopec merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
- metric.rb: Inline single-use constants into the Yabeda.configure block - middleware.rb: Extract measure_queue_time to shrink call to 2 lines, collapse two indirection methods (request_start_timestamp, parse_header_timestamp) into one, use [x, 0].max clamping pattern, endless methods for single-expression inner classes, remove unused parser: keyword arg, inline header key strings - header_timestamp_parser.rb: Inline trivial one-liner helpers (first_header_value, extract_numeric_token), use find + between? for normalize, shorten constant names, implicit nil returns Line counts: middleware 52 (was 85), parser 31 (was 51), metric 12 (was 27). All methods ≤5 lines, all classes well under 100, max 4 params. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.