Set resource_name in .tx/config files to preserve resource naming behavior prior to 2.1.0#90
Merged
Conversation
m-aciek
reviewed
Jun 14, 2023
…avior prior to 2.1.0
Contributor
Author
|
@m-aciek I've added a test and updated my commit with the suggestion. |
Contributor
|
Confirmed it is working. It successfully adds "resource_name" field to each resource entry and pushing to Transifex sends the expected resource name. Thanks for that! Can you also add a Feature entry to CHANGES file? |
Contributor
Author
|
I've added an entry :) |
rffontenelle
approved these changes
Jun 19, 2023
Contributor
Author
|
Is there anything blocking a merge? |
Member
|
@jpmckinney tests failed on master, please could you provide a fix? Otherwise we'll need to revert. A |
Contributor
Author
|
I'll look into it! |
Contributor
Author
|
I'm unable to reproduce and I installed the same versions of packages as listed by pip freeze in the workflow. |
Contributor
Author
|
Aha, something changed in |
Contributor
Author
|
Okay, tx just changed the whitespace alignment: #96 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #88