feat(css-map): update css-map for 1.2.72#3511
feat(css-map): update css-map for 1.2.72#3511rxri merged 3 commits intospicetify:mainfrom veryboringhwl:update-classname
Conversation
WalkthroughBulk updates to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.2.334)css-map.jsoncheckov: error while loading shared libraries: libdl.so.2: cannot open shared object file: No such file or directory 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
css-map.json (1)
1-1616: Prevent duplicate keys in css-map.json via CI guard
Detected duplicate keyKMMqgUnvRAqSSii6zn7L. Remove or consolidate the duplicate entry and add a CI/pre-commit check to fail on any future collisions, for example:#!/bin/bash awk ' match($0, /^\s*"([^"]+)"\s*:/, m) { k=m[1] if (seen[k]++) dups[k]++ } END { if (length(dups)) { echo "Duplicate keys detected in css-map.json:" >&2 for (k in dups) echo " - " k >&2 exit 1 } } ' css-map.json
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
css-map.json(43 hunks)
🧰 Additional context used
🪛 GitHub Actions: Code quality
css-map.json
[error] 847-847: biome ci: Duplicate key 'KMMqgUnvRAqSSii6zn7L' detected in css-map.json (line 847).
🔇 Additional comments (1)
css-map.json (1)
1487-1492: Double-check downstream usage of nameContainer mapping
No references to eitherview-homeShortcutsGrid-nameorview-homeShortcutsGrid-nameContainerfound outsidecss-map.json; ensure components relying on the old “name” selector are updated to use “nameContainer” (or remove any orphaned mappings).
Spotify changed many classnames in new version
Added view-homeShortcutsGrid-nameContainer, as the shortcut name and the container had the same classname but different obfuscated classname
Summary by CodeRabbit