Snowflake aggregation pushdown support#620
Merged
Conversation
mildbyte
reviewed
Jan 27, 2022
mildbyte
approved these changes
Jan 27, 2022
| elif data_source == "pg": | ||
| assert _extract_pg_queries_from_explain(result)[0] == ( | ||
| 'SELECT avg(public.account.balance) AS "avg.balance", count(*) AS "count.*" ' | ||
| "FROM public.account WHERE public.account.firstname LIKE 'Su_an%%'" |
Contributor
There was a problem hiding this comment.
The original query has WHERE firstname ~~ 'Su_an%' whereas this one has WHERE public.account.firstname LIKE 'Su_an%%' -- shouldn't it also only have one percentage sign?
Contributor
Author
There was a problem hiding this comment.
As discussed offline, the answer is no, and the reason is documeted here: https://docs.sqlalchemy.org/en/14/faq/sqlexpressions.html#why-are-percent-signs-being-doubled-up-when-stringifying-sql-statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multicorn.sqlalchemyfdw.SqlAlchemyFdwCU-23kfzuz